Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staking] make contract staking indexer nullable #3883

Merged
merged 8 commits into from
Jul 11, 2023
Merged

[staking] make contract staking indexer nullable #3883

merged 8 commits into from
Jul 11, 2023
+63 −159

Conversation

envestcc
Copy link
Member

@envestcc envestcc commented Jun 7, 2023

Description

To improve flexibility and testability, make the contract staking indexer param in staking.NewProtocol() nullable.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@envestcc envestcc requested review from CoderZhi, dustinxie, Liuhaai and a team as code owners June 7, 2023 14:38
@envestcc envestcc mentioned this pull request Jun 7, 2023
Closed
10 tasks
@codecov
Copy link

codecov bot commented Jun 7, 2023 •
edited
Loading

Codecov Report

Merging #3883 (7037b26) into master (e1f0636) will increase coverage by 0.23%.
The diff coverage is 67.58%.

❗ Current head 7037b26 differs from pull request most recent head b498078. Consider uploading reports for the commit b498078 to get more accurate results

@@            Coverage Diff             @@
##           master    #3883      +/-   ##
==========================================
+ Coverage   75.38%   75.61%   +0.23%     
==========================================
  Files         303      326      +23     
  Lines       25923    27802    +1879     
==========================================
+ Hits        19541    21023    +1482     
- Misses       5360     5694     +334     
- Partials     1022     1085      +63
Impacted Files Coverage Δ
action/protocol/execution/evm/evm.go 43.52% <0.00%> (-2.95%) ⬇️
action/protocol/execution/evm/evmstatedbadapter.go 66.77% <ø> (ø)
action/protocol/poll/consortium.go 0.00% <0.00%> (ø)
action/protocol/poll/staking_committee.go 43.85% <0.00%> (ø)
...tion/protocol/staking/contractstake_bucket_type.go 0.00% <0.00%> (ø)
api/grpcserver.go 86.40% <0.00%> (ø)
api/loglistener.go 25.00% <0.00%> (ø)
api/web3server_marshal.go 93.21% <ø> (ø)
api/websocket.go 5.17% <0.00%> (ø)
blockchain/config.go 74.54% <ø> (ø)
... and 49 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@envestcc envestcc mentioned this pull request Jun 7, 2023
Closed
10 tasks
@envestcc envestcc force-pushed the contractindexer_nullable branch 2 times, most recently from 4b1ded7 to f7633fd Compare July 6, 2023 02:22
@sonarcloud
Copy link

sonarcloud bot commented Jul 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
17.7% 17.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@envestcc envestcc merged commit 1e01082 into iotexproject:master Jul 11, 2023
@envestcc envestcc deleted the contractindexer_nullable branch July 11, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liuhaai Liuhaai Liuhaai approved these changes

@dustinxie dustinxie dustinxie approved these changes

@CoderZhi CoderZhi Awaiting requested review from CoderZhi CoderZhi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@envestcc @dustinxie @Liuhaai